diff options
| author | Joshua Peraza <jperaza@chromium.org> | 2017-01-19 11:18:41 -0800 |
|---|---|---|
| committer | Joshua Peraza <jperaza@chromium.org> | 2017-01-19 19:33:56 +0000 |
| commit | 0924d424e444d57dd95c647652a11f2d655c11a0 (patch) | |
| tree | 03023e635cd25fbaf8b532c3151f6b397bcd12b4 /src/google_breakpad/processor/minidump.h | |
| parent | Add API to skip dump if crashing thread doesn't reference a given module (2) (diff) | |
| download | breakpad-0924d424e444d57dd95c647652a11f2d655c11a0.tar.xz | |
Populate stack frames with unloaded module info.
This CL hits lots of source files because:
1. An update to the CodeModule virtual class. I added an is_loaded
method to specify whether the module is loaded. There were several
mocks/test classes that needed to be updated with an implementation.
An alternative to this route would be to modify
MinidumpUnloadedModule::code_file to prepend "Unloaded_" to the
module name.
2. Added an unloaded_modules parameter to
StackFrameSymbolizer::FillSourceLineInfo.
BUG=
Change-Id: Ic9c7f7c7b7e932a154a5d4ccf292c1527d8da09f
Reviewed-on: https://chromium-review.googlesource.com/430241
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
Diffstat (limited to 'src/google_breakpad/processor/minidump.h')
| -rw-r--r-- | src/google_breakpad/processor/minidump.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/google_breakpad/processor/minidump.h b/src/google_breakpad/processor/minidump.h index 1bfc7d9e..bff38bf3 100644 --- a/src/google_breakpad/processor/minidump.h +++ b/src/google_breakpad/processor/minidump.h @@ -399,6 +399,7 @@ class MinidumpModule : public MinidumpObject, virtual string debug_identifier() const; virtual string version() const; virtual CodeModule* Copy() const; + virtual bool is_unloaded() const { return false; } // Getter and setter for shrink_down_delta. This is used when the address // range for a module is shrunk down due to address range conflicts with @@ -775,6 +776,7 @@ class MinidumpUnloadedModule : public MinidumpObject, string debug_identifier() const override; string version() const override; CodeModule* Copy() const override; + bool is_unloaded() const override { return true; } uint64_t shrink_down_delta() const override; void SetShrinkDownDelta(uint64_t shrink_down_delta) override; |