diff options
author | ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-10-01 13:01:57 +0000 |
---|---|---|
committer | ted.mielczarek <ted.mielczarek@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-10-01 13:01:57 +0000 |
commit | 8c33b3e9c95a67a9bb06c033d5d4c28d9a55168b (patch) | |
tree | ef075e1413f52c73ce23e3a967d4cfa1311745e1 /src/google_breakpad/processor/stack_frame_cpu.h | |
parent | Fix a segmentation fault bug in MinidumpAssertion::Read(). (diff) | |
download | breakpad-8c33b3e9c95a67a9bb06c033d5d4c28d9a55168b.tar.xz |
Refactor some bits of StackWalkerX86 / StackFrameX86 out into their respective parent classes so they can be used by other architecture implementations.
R=jimb at http://breakpad.appspot.com/205001/show
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@703 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/google_breakpad/processor/stack_frame_cpu.h')
-rw-r--r-- | src/google_breakpad/processor/stack_frame_cpu.h | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/src/google_breakpad/processor/stack_frame_cpu.h b/src/google_breakpad/processor/stack_frame_cpu.h index 0996886f..805b6bc3 100644 --- a/src/google_breakpad/processor/stack_frame_cpu.h +++ b/src/google_breakpad/processor/stack_frame_cpu.h @@ -70,23 +70,9 @@ struct StackFrameX86 : public StackFrame { CONTEXT_VALID_ALL = -1 }; - // Indicates how well we trust the instruction pointer we derived - // during stack walking. Since the stack walker can resort to - // stack scanning, we can wind up with dubious frames. - // In rough order of "trust metric". - enum FrameTrust { - FRAME_TRUST_NONE, // Unknown - FRAME_TRUST_SCAN, // Scanned the stack, found this - FRAME_TRUST_CFI_SCAN, // Scanned the stack using call frame info, found this - FRAME_TRUST_FP, // Derived from frame pointer - FRAME_TRUST_CFI, // Derived from call frame info - FRAME_TRUST_CONTEXT // Given as instruction pointer in a context - }; - StackFrameX86() : context(), context_validity(CONTEXT_VALID_NONE), - trust(FRAME_TRUST_NONE), windows_frame_info(NULL), cfi_frame_info(NULL) {} ~StackFrameX86(); @@ -101,10 +87,6 @@ struct StackFrameX86 : public StackFrame { // the OR operator doesn't work well with enumerated types. This indicates // which fields in context are valid. int context_validity; - - // Amount of trust the stack walker has in the instruction pointer - // of this frame. - FrameTrust trust; // Any stack walking information we found describing this.instruction. // These may be NULL if there is no such information for that address. |