diff options
| author | Liu.andrew.x@gmail.com <Liu.andrew.x@gmail.com> | 2015-07-31 15:26:39 +0000 |
|---|---|---|
| committer | Liu.andrew.x@gmail.com <Liu.andrew.x@gmail.com> | 2015-07-31 15:26:39 +0000 |
| commit | 0dbae0cf3f2d3614bd7cb6ec9b6ad006e6ec1917 (patch) | |
| tree | 27c4955546e7ec60cd3d51a7a2c1d653655c3f86 /src/google_breakpad/processor | |
| parent | Remove unnecessary dependencies. (diff) | |
| download | breakpad-0dbae0cf3f2d3614bd7cb6ec9b6ad006e6ec1917.tar.xz | |
Fix potential null pointer dereference.
If a MinidumpLinuxMapsList was created and destroyed without its Read method,
the program would have a segmentation fault because the destructor did not
check for a null maps_ field. Additional changes include additional
supplementary null checks, a potential memory leak fix, and some comment
removal.
Review URL: https://codereview.chromium.org/1271543002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1478 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/google_breakpad/processor')
| -rw-r--r-- | src/google_breakpad/processor/minidump.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/google_breakpad/processor/minidump.h b/src/google_breakpad/processor/minidump.h index 9c8448a3..c6273cff 100644 --- a/src/google_breakpad/processor/minidump.h +++ b/src/google_breakpad/processor/minidump.h @@ -901,10 +901,6 @@ class MinidumpLinuxMaps : public MinidumpObject { // This caller owns the pointer. explicit MinidumpLinuxMaps(Minidump *minidump); - // Read data about a single mapping from /proc/self/maps and load the data - // into this object. The input vector is in the same format as a line from - // /proc/self/maps. - // The memory region struct that this class wraps. MappedMemoryRegion region_; |