diff options
| author | chrisha@chromium.org <chrisha@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-08-23 19:41:36 +0000 |
|---|---|---|
| committer | chrisha@chromium.org <chrisha@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-08-23 19:41:36 +0000 |
| commit | 16a880e1356959f2c5747ecb09dd1da60ef7b665 (patch) | |
| tree | d67c2711837323128f0b0d5a8447b39d1aa8f69e /src/google_breakpad/processor | |
| parent | Create StackwalkerAddressList. (diff) | |
| download | breakpad-16a880e1356959f2c5747ecb09dd1da60ef7b665.tar.xz | |
Create StackFrame::FRAME_TRUST_PREWALKED trust type.
This creates a new frame trust type for prewalked stack frames, as suggested in
the review of https://breakpad.appspot.com/620002/.
R=ted.mielczarek@gmail.com, mark@chromium.org
Review URL: https://breakpad.appspot.com/621002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1208 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/google_breakpad/processor')
| -rw-r--r-- | src/google_breakpad/processor/stack_frame.h | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/google_breakpad/processor/stack_frame.h b/src/google_breakpad/processor/stack_frame.h index 23e69bb4..b55eb9c7 100644 --- a/src/google_breakpad/processor/stack_frame.h +++ b/src/google_breakpad/processor/stack_frame.h @@ -45,12 +45,13 @@ struct StackFrame { // stack scanning, it can wind up with dubious frames. // In rough order of "trust metric". enum FrameTrust { - FRAME_TRUST_NONE, // Unknown - FRAME_TRUST_SCAN, // Scanned the stack, found this - FRAME_TRUST_CFI_SCAN, // Scanned the stack using call frame info, found this - FRAME_TRUST_FP, // Derived from frame pointer - FRAME_TRUST_CFI, // Derived from call frame info - FRAME_TRUST_CONTEXT // Given as instruction pointer in a context + FRAME_TRUST_NONE, // Unknown + FRAME_TRUST_SCAN, // Scanned the stack, found this + FRAME_TRUST_CFI_SCAN, // Found while scanning stack using call frame info + FRAME_TRUST_FP, // Derived from frame pointer + FRAME_TRUST_CFI, // Derived from call frame info + FRAME_TRUST_PREWALKED, // Explicitly provided by some external stack walker. + FRAME_TRUST_CONTEXT // Given as instruction pointer in a context }; StackFrame() @@ -70,6 +71,8 @@ struct StackFrame { switch (trust) { case StackFrame::FRAME_TRUST_CONTEXT: return "given as instruction pointer in context"; + case StackFrame::FRAME_TRUST_PREWALKED: + return "recovered by external stack walker"; case StackFrame::FRAME_TRUST_CFI: return "call frame info"; case StackFrame::FRAME_TRUST_CFI_SCAN: |