diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-05-08 02:37:15 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-05-08 02:37:15 +0000 |
| commit | b45b97b2fd735eea5f0e5824b0a48132ccafd88e (patch) | |
| tree | b9335342914d6f9452fa2526f98b7834467f67b7 /src/google_breakpad | |
| parent | Add MD_OS_NACL platform_id value for identifying NaCl minidumps (diff) | |
| download | breakpad-b45b97b2fd735eea5f0e5824b0a48132ccafd88e.tar.xz | |
Make x86-64 stack walking work for Native Client minidumps
For NaCl, a stack walker should ignore the top 32 bits of %rip, %rsp
and %rbp, otherwise it will try to read from %r15-extended stack
addresses and look up symbol info for %r15-extended code addresses,
which will fail.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested manually with a NaCl minidump
Review URL: https://breakpad.appspot.com/591002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1173 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/google_breakpad')
| -rw-r--r-- | src/google_breakpad/processor/system_info.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/google_breakpad/processor/system_info.h b/src/google_breakpad/processor/system_info.h index 4a250482..9583d9e8 100644 --- a/src/google_breakpad/processor/system_info.h +++ b/src/google_breakpad/processor/system_info.h @@ -63,10 +63,11 @@ struct SystemInfo { string os; // A short form of the os string, using lowercase letters and no spaces, - // suitable for use in a filesystem. Possible values are "windows", - // "mac", and "linux". Empty if the information is not present in the dump - // or if the OS given by the dump is unknown. The values stored in this - // field should match those used by MinidumpSystemInfo::GetOS. + // suitable for use in a filesystem. Possible values include "windows", + // "mac", "linux" and "nacl". Empty if the information is not present + // in the dump or if the OS given by the dump is unknown. The values + // stored in this field should match those used by + // MinidumpSystemInfo::GetOS. string os_short; // A string identifying the version of the operating system, such as |