diff options
| author | Liu.andrew.x@gmail.com <Liu.andrew.x@gmail.com> | 2015-06-30 20:34:39 +0000 |
|---|---|---|
| committer | Liu.andrew.x@gmail.com <Liu.andrew.x@gmail.com> | 2015-06-30 20:34:39 +0000 |
| commit | 12213a5e15b60f0027fb2271908f4d52494a617b (patch) | |
| tree | 6e15d03a81be492f74b69d95058337aee4383112 /src/processor/exploitability_unittest.cc | |
| parent | This CL adds support for ARM and ARM64 architectures when calculating (diff) | |
| download | breakpad-12213a5e15b60f0027fb2271908f4d52494a617b.tar.xz | |
Checking for benign exceptions that trigger a minidump.
If the exception reponsible for the crash is benign, such as a floating point
exception, we can rule out the possibility that the code is exploitable. This
CL checks for such exceptions and marks the dump as not exploitable if such an
exception is found.
R=ivanpe@chromium.org
Review URL: https://codereview.chromium.org/1212383004
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1467 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/exploitability_unittest.cc')
| -rw-r--r-- | src/processor/exploitability_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/processor/exploitability_unittest.cc b/src/processor/exploitability_unittest.cc index 509ae230..cc46f9ea 100644 --- a/src/processor/exploitability_unittest.cc +++ b/src/processor/exploitability_unittest.cc @@ -107,7 +107,7 @@ TEST(ExploitabilityTest, TestWindowsEngine) { } TEST(ExploitabilityTest, TestLinuxEngine) { - ASSERT_EQ(google_breakpad::EXPLOITABILITY_NONE, + ASSERT_EQ(google_breakpad::EXPLOITABILITY_INTERESTING, ExploitabilityFor("linux_null_read_av.dmp")); ASSERT_EQ(google_breakpad::EXPLOITABILITY_HIGH, ExploitabilityFor("linux_overflow.dmp")); @@ -115,7 +115,7 @@ TEST(ExploitabilityTest, TestLinuxEngine) { ExploitabilityFor("linux_stacksmash.dmp")); ASSERT_EQ(google_breakpad::EXPLOITABILITY_NONE, ExploitabilityFor("linux_divide_by_zero.dmp")); - ASSERT_EQ(google_breakpad::EXPLOITABILITY_NONE, + ASSERT_EQ(google_breakpad::EXPLOITABILITY_INTERESTING, ExploitabilityFor("linux_null_dereference.dmp")); ASSERT_EQ(google_breakpad::EXPLOITABILITY_HIGH, ExploitabilityFor("linux_jmp_to_0.dmp")); |