diff options
author | mmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2006-09-07 15:56:38 +0000 |
---|---|---|
committer | mmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2006-09-07 15:56:38 +0000 |
commit | 53d0f69d35375fe2ffd119ac7e4898083c0e071c (patch) | |
tree | eb79c57964db5b3567102bd4fa43f2beaf644e0c /src/processor/memory_region.h | |
parent | minidump_dump test is timezone-dependent (#15). r=bryner (diff) | |
download | breakpad-53d0f69d35375fe2ffd119ac7e4898083c0e071c.tar.xz |
Conform to style guidelines.
- In class definitions, one-space indent for public/protected/private.
- Multi-line initializer format puts comma at end of line.
Also:
- Eliminate the long list of friends in Minidump by making swap() public.
(People who need to access unknown stream types directly will need
access to swap() too.)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@16 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/memory_region.h')
-rw-r--r-- | src/processor/memory_region.h | 46 |
1 files changed, 21 insertions, 25 deletions
diff --git a/src/processor/memory_region.h b/src/processor/memory_region.h index 83d6dbf4..c1d9f408 100644 --- a/src/processor/memory_region.h +++ b/src/processor/memory_region.h @@ -31,31 +31,27 @@ namespace google_airbag { class MemoryRegion { - public: - virtual ~MemoryRegion() {} - - // The base address of this memory region. - virtual u_int64_t GetBase() = 0; - - // The size of this memory region. - virtual u_int32_t GetSize() = 0; - - // Access to data of various sizes within the memory region. address - // is a pointer to read, and it must lie within the memory region as - // defined by its base address and size. The location pointed to by - // value is set to the value at address. Byte-swapping is performed - // if necessary so that the value is appropriate for the running - // program. Returns true on success. Fails and returns false if address - // is out of the region's bounds (after considering the width of value), - // or for other types of errors. - virtual bool GetMemoryAtAddress(u_int64_t address, - u_int8_t* value) = 0; - virtual bool GetMemoryAtAddress(u_int64_t address, - u_int16_t* value) = 0; - virtual bool GetMemoryAtAddress(u_int64_t address, - u_int32_t* value) = 0; - virtual bool GetMemoryAtAddress(u_int64_t address, - u_int64_t* value) = 0; + public: + virtual ~MemoryRegion() {} + + // The base address of this memory region. + virtual u_int64_t GetBase() = 0; + + // The size of this memory region. + virtual u_int32_t GetSize() = 0; + + // Access to data of various sizes within the memory region. address + // is a pointer to read, and it must lie within the memory region as + // defined by its base address and size. The location pointed to by + // value is set to the value at address. Byte-swapping is performed + // if necessary so that the value is appropriate for the running + // program. Returns true on success. Fails and returns false if address + // is out of the region's bounds (after considering the width of value), + // or for other types of errors. + virtual bool GetMemoryAtAddress(u_int64_t address, u_int8_t* value) = 0; + virtual bool GetMemoryAtAddress(u_int64_t address, u_int16_t* value) = 0; + virtual bool GetMemoryAtAddress(u_int64_t address, u_int32_t* value) = 0; + virtual bool GetMemoryAtAddress(u_int64_t address, u_int64_t* value) = 0; }; |