diff options
| author | Joshua Peraza <jperaza@chromium.org> | 2017-01-19 11:18:41 -0800 |
|---|---|---|
| committer | Joshua Peraza <jperaza@chromium.org> | 2017-01-19 19:33:56 +0000 |
| commit | 0924d424e444d57dd95c647652a11f2d655c11a0 (patch) | |
| tree | 03023e635cd25fbaf8b532c3151f6b397bcd12b4 /src/processor/microdump_processor.cc | |
| parent | Add API to skip dump if crashing thread doesn't reference a given module (2) (diff) | |
| download | breakpad-0924d424e444d57dd95c647652a11f2d655c11a0.tar.xz | |
Populate stack frames with unloaded module info.
This CL hits lots of source files because:
1. An update to the CodeModule virtual class. I added an is_loaded
method to specify whether the module is loaded. There were several
mocks/test classes that needed to be updated with an implementation.
An alternative to this route would be to modify
MinidumpUnloadedModule::code_file to prepend "Unloaded_" to the
module name.
2. Added an unloaded_modules parameter to
StackFrameSymbolizer::FillSourceLineInfo.
BUG=
Change-Id: Ic9c7f7c7b7e932a154a5d4ccf292c1527d8da09f
Reviewed-on: https://chromium-review.googlesource.com/430241
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
Diffstat (limited to 'src/processor/microdump_processor.cc')
| -rw-r--r-- | src/processor/microdump_processor.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/processor/microdump_processor.cc b/src/processor/microdump_processor.cc index 366e3f30..2d67f861 100644 --- a/src/processor/microdump_processor.cc +++ b/src/processor/microdump_processor.cc @@ -73,6 +73,7 @@ ProcessResult MicrodumpProcessor::Process(const string µdump_contents, microdump.GetContext(), microdump.GetMemory(), process_state->modules_, + /* unloaded_modules= */ NULL, frame_symbolizer_)); scoped_ptr<CallStack> stack(new CallStack()); |