diff options
| author | jschuh@chromium.org <jschuh@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2009-10-19 18:10:49 +0000 |
|---|---|---|
| committer | jschuh@chromium.org <jschuh@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2009-10-19 18:10:49 +0000 |
| commit | 5f4fa55598baf92785223debe7d3787c6b29cf3e (patch) | |
| tree | 195a50f10733db124f17faa88d90ef743aae07c7 /src/processor/minidump.cc | |
| parent | Allow the Breakpad Mac framework to be built without -fexceptions. (diff) | |
| download | breakpad-5f4fa55598baf92785223debe7d3787c6b29cf3e.tar.xz | |
Issue 35001: Fallback to Thread Context on bad Exception Context
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@418 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/minidump.cc')
| -rw-r--r-- | src/processor/minidump.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc index 1a60d834..cd6da170 100644 --- a/src/processor/minidump.cc +++ b/src/processor/minidump.cc @@ -608,8 +608,9 @@ bool MinidumpContext::Read(u_int32_t expected_size) { } default: { - // Unknown context type - BPLOG(ERROR) << "MinidumpContext unknown context type " << + // Unknown context type - Don't log as an error yet. Let the + // caller work that out. + BPLOG(INFO) << "MinidumpContext unknown context type " << HexString(cpu_type); return false; break; @@ -2713,8 +2714,10 @@ MinidumpContext* MinidumpException::GetContext() { scoped_ptr<MinidumpContext> context(new MinidumpContext(minidump_)); + // Don't log as an error if we can still fall back on th thread's context + // (which must be possible if we got his far.) if (!context->Read(exception_.thread_context.data_size)) { - BPLOG(ERROR) << "MinidumpException cannot read context"; + BPLOG(INFO) << "MinidumpException cannot read context"; return NULL; } |