diff options
| author | jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-02-05 17:17:24 +0000 |
|---|---|---|
| committer | jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-02-05 17:17:24 +0000 |
| commit | 2214cb9bc1872cafae9127778c0cba556c89e43d (patch) | |
| tree | 9106ebba828abbb1eaf6fc0bed593ec113428a7a /src/processor/postfix_evaluator.h | |
| parent | Breakpad processor: Save Windows unwinding data earlier in x86 walker. (diff) | |
| download | breakpad-2214cb9bc1872cafae9127778c0cba556c89e43d.tar.xz | |
Breakpad processor: Make PostfixEvaluator treat the MemoryRegion as const.
In order to be able to treat any MemoryRegion as const, the accessor
functions need to be declared this-const, which means annotations on
all the subclasses, etc. etc.
Since MinidumpMemoryRegion fills its memory_ member on demand, that
member needs to be marked 'mutable', but this is exactly the sort of
situation the 'mutable' keyword was intended for, so that seems all
right.
a=jimblandy, r=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@509 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/postfix_evaluator.h')
| -rw-r--r-- | src/processor/postfix_evaluator.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/processor/postfix_evaluator.h b/src/processor/postfix_evaluator.h index 552ed159..d70bcaa0 100644 --- a/src/processor/postfix_evaluator.h +++ b/src/processor/postfix_evaluator.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006, Google Inc. +// Copyright (c) 2010, Google Inc. // All rights reserved. // // Redistribution and use in source and binary forms, with or without @@ -90,7 +90,7 @@ class PostfixEvaluator { // (^) will not be supported. |dictionary| may be NULL, but evaluation // will fail in that case unless set_dictionary is used before calling // Evaluate. - PostfixEvaluator(DictionaryType *dictionary, MemoryRegion *memory) + PostfixEvaluator(DictionaryType *dictionary, const MemoryRegion *memory) : dictionary_(dictionary), memory_(memory), stack_() {} // Evaluate the expression. The results of execution will be stored @@ -144,7 +144,7 @@ class PostfixEvaluator { // If non-NULL, the MemoryRegion used for dereference (^) operations. // If NULL, dereferencing is unsupported and will fail. Weak pointer. - MemoryRegion *memory_; + const MemoryRegion *memory_; // The stack contains state information as execution progresses. Values // are pushed on to it as the expression string is read and as operations |