diff options
| author | Ivan Penkov <ivanpe@chromium.org> | 2016-06-20 11:14:47 -0700 |
|---|---|---|
| committer | Ivan Penkov <ivanpe@chromium.org> | 2016-06-20 11:14:47 -0700 |
| commit | 24f5931c5e0120982c0cbf1896641e3ef2bdd52f (patch) | |
| tree | 68b24e2ded67b0cabcfb7c6e534e17640997e7b9 /src/processor/range_map-inl.h | |
| parent | linux-syscall-support: pull in latest version (diff) | |
| download | breakpad-24f5931c5e0120982c0cbf1896641e3ef2bdd52f.tar.xz | |
Server-side workaround to handle overlapping modules.
This change is resolving an issue that was caused by the combination of:
- Android system libraries being relro packed in N+.
- Breakpad dealing with relro packed libraries in a hack way.
This is a fix for http://crbug/611824.
I also found an use-after-free issue (bug in Minidump::SeekToStreamType). I disallowed the MinidumpStreamInfo copy and assign constructors and the compiler detected another similar issue in Minidump::Print. Then I disabled the copy and assign constructors for most classes in minidump.h (just in case). There are a couple of classes where I couldn't disallow them (since assign is used). This will require a small refactor so I left it out of this CL.
R=mark@chromium.org
Review URL: https://codereview.chromium.org/2060663002 .
Diffstat (limited to 'src/processor/range_map-inl.h')
| -rw-r--r-- | src/processor/range_map-inl.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/processor/range_map-inl.h b/src/processor/range_map-inl.h index 082733e1..9fe74c50 100644 --- a/src/processor/range_map-inl.h +++ b/src/processor/range_map-inl.h @@ -53,6 +53,11 @@ void RangeMap<AddressType, EntryType>::SetEnableShrinkDown( } template<typename AddressType, typename EntryType> +bool RangeMap<AddressType, EntryType>::IsShrinkDownEnabled() const { + return enable_shrink_down_; +} + +template<typename AddressType, typename EntryType> bool RangeMap<AddressType, EntryType>::StoreRange(const AddressType &base, const AddressType &size, const EntryType &entry) { |