diff options
| author | mmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2006-11-06 19:34:19 +0000 |
|---|---|---|
| committer | mmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2006-11-06 19:34:19 +0000 |
| commit | 80866e79454cefc5570b01dbb0a723185eae653c (patch) | |
| tree | b7aaf22c6d808a23a66756fc99d50d3fab44a695 /src/processor/simple_symbol_supplier.h | |
| parent | Fix minor naming inconsistency (#67). r=mmentovai (diff) | |
| download | breakpad-80866e79454cefc5570b01dbb0a723185eae653c.tar.xz | |
Symbol file should contain module GUID at beginning (#66). r=bryner
- The dumped symbol format now begins with a MODULE line identifying the
uuid, age, and name of the source pdb file.
- The processor ignores MODULE lines, but they are useful in figuring out
how to index symbol files in a symbol store.
- dump_syms and symupload now both accept either a pdb or exe/dll and
will read the pdb regardless.
- Figured out that MSSS always represents a module's age in pathnames in
hexadecimal, and updated SimpleSymbolSupplier to match.
http://groups.google.com/group/airbag-dev/browse_thread/thread/572108d6567edd58
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@59 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/simple_symbol_supplier.h')
| -rw-r--r-- | src/processor/simple_symbol_supplier.h | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/processor/simple_symbol_supplier.h b/src/processor/simple_symbol_supplier.h index 16d95057..4db8810c 100644 --- a/src/processor/simple_symbol_supplier.h +++ b/src/processor/simple_symbol_supplier.h @@ -36,8 +36,8 @@ // directory with a name identical to the corresponding pdb file. Within // each of these directories, there are subdirectories named for the uuid and // age of each pdb file. The uuid is presented in hexadecimal form, with -// uppercase characters and no dashes. The age is appended to it in decimal -// form, without any separators. Within that subdirectory, +// uppercase characters and no dashes. The age is appended to it in +// hexadecimal form, without any separators. Within that subdirectory, // SimpleSymbolSupplier expects to find the symbol file, which is named // identically to the pdb file, but with a .sym extension. This sample // hierarchy is rooted at the "symbols" base directory: @@ -59,9 +59,6 @@ // SimpleSymbolServer, provided that the pdb files are transformed to dumped // format using a tool such as dump_syms, and given a .sym extension. // -// TODO(mmentovai): verify that MSSS stores the age as presented as decimal -// and not hexadecimal or something else. Adjust here to match if necessary. -// // SimpleSymbolSupplier presently only supports symbol files that have // the MSVC 7.0 CodeView record format. See MDCVInfoPDB70 in // minidump_format.h. |