aboutsummaryrefslogtreecommitdiff
path: root/src/processor/stackwalker.h
diff options
context:
space:
mode:
authormmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2006-09-07 15:56:38 +0000
committermmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2006-09-07 15:56:38 +0000
commit53d0f69d35375fe2ffd119ac7e4898083c0e071c (patch)
treeeb79c57964db5b3567102bd4fa43f2beaf644e0c /src/processor/stackwalker.h
parentminidump_dump test is timezone-dependent (#15). r=bryner (diff)
downloadbreakpad-53d0f69d35375fe2ffd119ac7e4898083c0e071c.tar.xz
Conform to style guidelines.
- In class definitions, one-space indent for public/protected/private. - Multi-line initializer format puts comma at end of line. Also: - Eliminate the long list of friends in Minidump by making swap() public. (People who need to access unknown stream types directly will need access to swap() too.) git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@16 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/stackwalker.h')
-rw-r--r--src/processor/stackwalker.h72
1 files changed, 36 insertions, 36 deletions
diff --git a/src/processor/stackwalker.h b/src/processor/stackwalker.h
index 1ae9a85d..96e993e7 100644
--- a/src/processor/stackwalker.h
+++ b/src/processor/stackwalker.h
@@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-// stackwalker.cc: Generic stackwalker.
+// stackwalker.h: Generic stackwalker.
//
// The Stackwalker class is an abstract base class providing common generic
// methods that apply to stacks from all systems. Specific implementations
@@ -39,41 +39,41 @@ class MinidumpModuleList;
class Stackwalker {
- public:
- virtual ~Stackwalker() {}
-
- // Produces a vector of StackFrames by calling GetContextFrame and
- // GetCallerFrame, and populating the returned frames with module
- // offset and name information if possible. The caller takes ownership
- // of the StackFrames object and is responsible for freeing it.
- StackFrames* Walk();
-
- protected:
- // memory identifies a MemoryRegion that provides the stack memory
- // for the stack to walk. modules, if non-NULL, is a MinidumpModuleList
- // that is used to look up which code module each stack frame is
- // associated with.
- Stackwalker(MemoryRegion* memory, MinidumpModuleList* modules);
-
- // The stack memory to walk. Subclasses will require this region to
- // get information from the stack.
- MemoryRegion* memory_;
-
- private:
- // Obtains the context frame, the innermost called procedure in a stack
- // trace. Returns false on failure.
- virtual bool GetContextFrame(StackFrame* frame) = 0;
-
- // Obtains a caller frame. Each call to GetCallerFrame should return the
- // frame that called the last frame returned by GetContextFrame or
- // GetCallerFrame. GetCallerFrame should return false on failure or
- // when there are no more caller frames (when the end of the stack has
- // been reached).
- virtual bool GetCallerFrame(StackFrame* frame) = 0;
-
- // A list of modules, for populating each StackFrame's module information.
- // This field is optional and may be NULL.
- MinidumpModuleList* modules_;
+ public:
+ virtual ~Stackwalker() {}
+
+ // Produces a vector of StackFrames by calling GetContextFrame and
+ // GetCallerFrame, and populating the returned frames with module
+ // offset and name information if possible. The caller takes ownership
+ // of the StackFrames object and is responsible for freeing it.
+ StackFrames* Walk();
+
+ protected:
+ // memory identifies a MemoryRegion that provides the stack memory
+ // for the stack to walk. modules, if non-NULL, is a MinidumpModuleList
+ // that is used to look up which code module each stack frame is
+ // associated with.
+ Stackwalker(MemoryRegion* memory, MinidumpModuleList* modules);
+
+ // The stack memory to walk. Subclasses will require this region to
+ // get information from the stack.
+ MemoryRegion* memory_;
+
+ private:
+ // Obtains the context frame, the innermost called procedure in a stack
+ // trace. Returns false on failure.
+ virtual bool GetContextFrame(StackFrame* frame) = 0;
+
+ // Obtains a caller frame. Each call to GetCallerFrame should return the
+ // frame that called the last frame returned by GetContextFrame or
+ // GetCallerFrame. GetCallerFrame should return false on failure or
+ // when there are no more caller frames (when the end of the stack has
+ // been reached).
+ virtual bool GetCallerFrame(StackFrame* frame) = 0;
+
+ // A list of modules, for populating each StackFrame's module information.
+ // This field is optional and may be NULL.
+ MinidumpModuleList* modules_;
};