diff options
| author | jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-02-05 17:46:41 +0000 |
|---|---|---|
| committer | jimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2010-02-05 17:46:41 +0000 |
| commit | 6a9ffff6963b3c5ab44580c45eac90f9b9ccab99 (patch) | |
| tree | ac872ea2976422dc603a78385adf621f54b8e27a /src/processor/stackwalker_x86.h | |
| parent | Breakpad processor: Make PostfixEvaluator treat the MemoryRegion as const. (diff) | |
| download | breakpad-6a9ffff6963b3c5ab44580c45eac90f9b9ccab99.tar.xz | |
Breakpad x86 Stack Walker: Pass "out" parameters by address, not reference.
The Google C++ Style Guide requires all parameters passed by reference
to be labeled 'const', and says that pointers should be used for
output arguments. This patch brings google_breakpad::StackwalkerX86
into line.
a=jimblandy, r=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@510 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/stackwalker_x86.h')
| -rw-r--r-- | src/processor/stackwalker_x86.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/processor/stackwalker_x86.h b/src/processor/stackwalker_x86.h index f77c6db8..255c16b3 100644 --- a/src/processor/stackwalker_x86.h +++ b/src/processor/stackwalker_x86.h @@ -79,8 +79,8 @@ class StackwalkerX86 : public Stackwalker { // the value was found, and eip_found to the value contained at that // location in memory. bool ScanForReturnAddress(u_int32_t location_start, - u_int32_t &location_found, - u_int32_t &eip_found); + u_int32_t *location_found, + u_int32_t *eip_found); // Stores the CPU context corresponding to the innermost stack frame to // be returned by GetContextFrame. |