aboutsummaryrefslogtreecommitdiff
path: root/src/processor/testdata/linux_executable_stack.dmp
diff options
context:
space:
mode:
authorMike Frysinger <vapier@chromium.org>2016-01-21 00:50:28 -0500
committerMike Frysinger <vapier@chromium.org>2016-01-21 00:50:28 -0500
commit8baa236daa9a2bab20e7b5cdaaee52c0de43cc40 (patch)
tree055a292403ea90d6ab71aca3f80ec9977968998a /src/processor/testdata/linux_executable_stack.dmp
parentFix usage of snprintf for MSVC (diff)
downloadbreakpad-8baa236daa9a2bab20e7b5cdaaee52c0de43cc40.tar.xz
exploitability_unittest: fix warnings
The std::getline function always returns its first arg (which is an iostream object) and cannot return anything else. Thus, testing its value is pointless, and even leads to build errors w/at least gcc-5 due to gtest ASSERT_TRUE funcs only taking bool types: .../exploitability_unittest.cc: In member function 'virtual void {anonymous}::ExploitabilityLinuxUtilsTest_DisassembleBytesTest_Test::TestBody()': .../exploitability_unittest.cc:200:136: error: no matching function for call to 'testing::AssertionResult::AssertionResult(std::basic_istream<char>&)' In file included from .../breakpad_googletest_includes.h:33:0, from .../exploitability_unittest.cc:35: .../gtest.h:262:12: note: candidate: testing::AssertionResult::AssertionResult(bool) Since we know this never fails, simply drop the ASSERT_TRUE usage. The next line already checks the content of the buffer we read. Further on in the file, we hit some signed warnings: In file included from .../breakpad_googletest_includes.h:33:0, from .../exploitability_unittest.cc:35: .../gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int]': .../gtest.h:1484:23: required from 'static testing::AssertionResult testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = long unsigned int; T2 = int; bool lhs_is_null_literal = false]' .../exploitability_unittest.cc:241:289: required from here .../gtest.h:1448:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (expected == actual) { This is because we compare the register value (a uint64_t) directly to an integer constant, and those are signed by default. Stick a U suffix on them to fix things up. BUG=chromium:579384 TEST=`make check` passes R=ivanpe@chromium.org Review URL: https://codereview.chromium.org/1611763002 .
Diffstat (limited to 'src/processor/testdata/linux_executable_stack.dmp')
0 files changed, 0 insertions, 0 deletions