diff options
| author | chrisha@chromium.org <chrisha@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-08-23 19:41:36 +0000 |
|---|---|---|
| committer | chrisha@chromium.org <chrisha@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2013-08-23 19:41:36 +0000 |
| commit | 16a880e1356959f2c5747ecb09dd1da60ef7b665 (patch) | |
| tree | d67c2711837323128f0b0d5a8447b39d1aa8f69e /src/processor | |
| parent | Create StackwalkerAddressList. (diff) | |
| download | breakpad-16a880e1356959f2c5747ecb09dd1da60ef7b665.tar.xz | |
Create StackFrame::FRAME_TRUST_PREWALKED trust type.
This creates a new frame trust type for prewalked stack frames, as suggested in
the review of https://breakpad.appspot.com/620002/.
R=ted.mielczarek@gmail.com, mark@chromium.org
Review URL: https://breakpad.appspot.com/621002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1208 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor')
| -rw-r--r-- | src/processor/stackwalker_address_list.cc | 2 | ||||
| -rw-r--r-- | src/processor/stackwalker_address_list_unittest.cc | 8 |
2 files changed, 8 insertions, 2 deletions
diff --git a/src/processor/stackwalker_address_list.cc b/src/processor/stackwalker_address_list.cc index fdc9b9ae..55656032 100644 --- a/src/processor/stackwalker_address_list.cc +++ b/src/processor/stackwalker_address_list.cc @@ -85,7 +85,7 @@ StackFrame* StackwalkerAddressList::GetCallerFrame(const CallStack* stack, // explicitly provided. StackFrame* frame = new StackFrame(); frame->instruction = frames_[frame_index]; - frame->trust = StackFrame::FRAME_TRUST_CONTEXT; + frame->trust = StackFrame::FRAME_TRUST_PREWALKED; return frame; } diff --git a/src/processor/stackwalker_address_list_unittest.cc b/src/processor/stackwalker_address_list_unittest.cc index 8af63fb1..2eb36cd7 100644 --- a/src/processor/stackwalker_address_list_unittest.cc +++ b/src/processor/stackwalker_address_list_unittest.cc @@ -106,8 +106,14 @@ class StackwalkerAddressListTest : public testing::Test { void CheckCallStack(const CallStack& call_stack) { const std::vector<StackFrame*>* frames = call_stack.frames(); ASSERT_EQ(arraysize(kDummyFrames), frames->size()); - for (size_t i = 0; i < arraysize(kDummyFrames); ++i) + for (size_t i = 0; i < arraysize(kDummyFrames); ++i) { ASSERT_EQ(kDummyFrames[i], frames->at(i)->instruction); + if (i == 0) { + ASSERT_EQ(StackFrame::FRAME_TRUST_CONTEXT, frames->at(i)->trust); + } else { + ASSERT_EQ(StackFrame::FRAME_TRUST_PREWALKED, frames->at(i)->trust); + } + } ASSERT_EQ(static_cast<const CodeModule*>(&module2), frames->at(0)->module); ASSERT_EQ(static_cast<const CodeModule*>(&module2), frames->at(1)->module); ASSERT_EQ(static_cast<const CodeModule*>(&module2), frames->at(2)->module); |