diff options
| author | Ted Mielczarek <ted@mielczarek.org> | 2018-03-09 15:45:38 -0500 |
|---|---|---|
| committer | Ted Mielczarek <ted@mielczarek.org> | 2018-03-12 09:59:33 +0000 |
| commit | 2d80611fedf1e6bce4459f179dafaac844e9fc7f (patch) | |
| tree | af74c1dd79fb4212a2f35867320c59c18c5458c4 /src/processor | |
| parent | Fixing incorrect include guard (missing #define) (diff) | |
| download | breakpad-2d80611fedf1e6bce4459f179dafaac844e9fc7f.tar.xz | |
Allow minidump_dump to print module lists that would normally be rejected
for being too long.
We've seen some minidumps that fail to process because they contain
a ridiculous number of modules (usually due to something leaking shm
mappings, it looks like). They're annoying to investigate because even
minidump_dump fails to load and print the module list. This patch makes
minidump_dump effectively remove the limit on the number of modules it
will load, so inspecting the dump by hand is possible.
R=vapier@chromium.org
Change-Id: I7a55387ca4aaad8664cd4d2651052da989366027
Reviewed-on: https://chromium-review.googlesource.com/957130
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/processor')
| -rw-r--r-- | src/processor/minidump_dump.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/processor/minidump_dump.cc b/src/processor/minidump_dump.cc index 867f47b5..4716aa08 100644 --- a/src/processor/minidump_dump.cc +++ b/src/processor/minidump_dump.cc @@ -121,6 +121,9 @@ static bool PrintMinidumpDump(const Options& options) { thread_list->Print(); } + // It's useful to be able to see the full list of modules here even if it + // would cause minidump_stackwalk to fail. + MinidumpModuleList::set_max_modules(UINT32_MAX); MinidumpModuleList *module_list = minidump.GetModuleList(); if (!module_list) { ++errors; |