diff options
| author | Joshua Peraza <jperaza@chromium.org> | 2017-03-03 16:09:37 -0800 |
|---|---|---|
| committer | Joshua Peraza <jperaza@chromium.org> | 2017-03-08 21:31:16 +0000 |
| commit | 5dbd93a0f8b8a79b00c74fe92a6806a8ff6f5b6f (patch) | |
| tree | 3b722eacc7e48ade1ab5ec21e35a9701a82e6293 /src/processor | |
| parent | [MIPS]: Relax dwarf section loading to accept both PROGBITS and MIPS_DWARF se... (diff) | |
| download | breakpad-5dbd93a0f8b8a79b00c74fe92a6806a8ff6f5b6f.tar.xz | |
Fix segfault when interpreting bad debug_file
BUG=chromium:661037
Change-Id: Ia4da0bd9787c232a6a199cfdfccfbed60c2515c2
Reviewed-on: https://chromium-review.googlesource.com/450090
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Diffstat (limited to 'src/processor')
| -rw-r--r-- | src/processor/minidump.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc index c9fa4d81..10400047 100644 --- a/src/processor/minidump.cc +++ b/src/processor/minidump.cc @@ -1988,7 +1988,9 @@ string MinidumpModule::debug_file() const { // GetMiscRecord already byte-swapped the data[] field if it contains // UTF-16, so pass false as the swap argument. scoped_ptr<string> new_file(UTF16ToUTF8(string_utf16, false)); - file = *new_file; + if (new_file.get() != nullptr) { + file = *new_file; + } } } } |