aboutsummaryrefslogtreecommitdiff
path: root/src/processor
diff options
context:
space:
mode:
authormmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2006-11-17 18:50:19 +0000
committermmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2006-11-17 18:50:19 +0000
commit7573d1dd4412171794f76bea833e4ae5f72929f8 (patch)
tree317a5b82431ad61514e3031b5620d0ad02c44fc2 /src/processor
parentMove some inlined functions to .cc file. Add some assertions. (diff)
downloadbreakpad-7573d1dd4412171794f76bea833e4ae5f72929f8.tar.xz
Modify SimpleSymbolSupplier for easier sublcassing (#75).
Patch by Ted Mielczarek <ted.mielczarek>. r=me http://groups.google.com/group/airbag-dev/browse_thread/thread/34690777576ccf7e git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@67 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor')
-rw-r--r--src/processor/simple_symbol_supplier.cc5
-rw-r--r--src/processor/simple_symbol_supplier.h7
2 files changed, 9 insertions, 3 deletions
diff --git a/src/processor/simple_symbol_supplier.cc b/src/processor/simple_symbol_supplier.cc
index 122ec489..3b59739e 100644
--- a/src/processor/simple_symbol_supplier.cc
+++ b/src/processor/simple_symbol_supplier.cc
@@ -39,7 +39,8 @@
namespace google_airbag {
-string SimpleSymbolSupplier::GetSymbolFile(MinidumpModule *module) {
+string SimpleSymbolSupplier::GetSymbolFileAtPath(MinidumpModule *module,
+ const string &root_path) {
// For now, only support modules that have GUIDs - which means
// MDCVInfoPDB70.
@@ -55,7 +56,7 @@ string SimpleSymbolSupplier::GetSymbolFile(MinidumpModule *module) {
return "";
// Start with the base path.
- string path = path_;
+ string path = root_path;
// Append the pdb file name as a directory name.
path.append("/");
diff --git a/src/processor/simple_symbol_supplier.h b/src/processor/simple_symbol_supplier.h
index dad34170..f9f52af1 100644
--- a/src/processor/simple_symbol_supplier.h
+++ b/src/processor/simple_symbol_supplier.h
@@ -88,7 +88,12 @@ class SimpleSymbolSupplier : public SymbolSupplier {
// Returns the path to the symbol file for the given module. See the
// description above.
- virtual string GetSymbolFile(MinidumpModule *module);
+ virtual string GetSymbolFile(MinidumpModule *module) {
+ return GetSymbolFileAtPath(module, path_);
+ }
+
+ protected:
+ string GetSymbolFileAtPath(MinidumpModule *module, const string &root_path);
private:
string path_;