diff options
| author | Nelson Billing <nbilling@google.com> | 2019-06-28 12:07:06 -0700 |
|---|---|---|
| committer | Nelson Billing <nbilling@google.com> | 2019-06-28 20:44:55 +0000 |
| commit | 9cafb376ebdf0d00a2fc2323e3eef26ccb27fa1d (patch) | |
| tree | 079f530fabd471c73cfd727c93a4e762436a8b77 /src/tools/mac/crash_report/on_demand_symbol_supplier.h | |
| parent | Fix clang build warnings/errors for windows symbol converter. (diff) | |
| download | breakpad-9cafb376ebdf0d00a2fc2323e3eef26ccb27fa1d.tar.xz | |
Explicitly LoadLibrary dbghelp.dll in symbol converter.
- This is a workaround to an issue with gn/clang build of Windows
symbol converter where dbghelp.dll is loaded from system32/syswow64
instead of alongside the process exe.
- Why do we care where dbghelp.dll is loaded from? Two considerations:
1. dbghelp.dll will only load symsrv.dll from the directory where it
resides.
2. symsrv.dll requires a file called "symsrv.yes" to be in the
directory where it resides in order to work with MS symbol stores.
Therefore if we load dbghelp.dll from syswow64, then we must also
ensure there is a symsrv.dll and symsrv.yes file in syswow64.
Change-Id: Ia283a2c11e276c855a48157aa7be77897af4b02e
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1680670
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
Diffstat (limited to 'src/tools/mac/crash_report/on_demand_symbol_supplier.h')
0 files changed, 0 insertions, 0 deletions