diff options
| author | Ivan Penkov <ivanpe@chromium.org> | 2016-09-02 14:26:23 -0700 |
|---|---|---|
| committer | Ivan Penkov <ivanpe@chromium.org> | 2016-09-02 21:50:30 +0000 |
| commit | b857dfec2b3302a4fca882471271f2e359f51665 (patch) | |
| tree | 33c93a44a40087b8a6bfcf71c28dfaa436f1000d /src/tools/mac/crash_report/on_demand_symbol_supplier.mm | |
| parent | Corrected some old references to mm files, which were renamed to cc files a w... (diff) | |
| download | breakpad-b857dfec2b3302a4fca882471271f2e359f51665.tar.xz | |
Fixing the Xcode project for the Breakpad Mac crash reporter.
Added new files elf_reader and corrected the references to dump_syms. Also some corrections to be able to build using a newer Xcode and SDK version (tested with Xcode 7.3, SDK 10.11).
Patch provided by Thomas Schweitzer.
BUG=
Change-Id: I18bd3f8ce0c1d0ceb737aee2fa8305adfcc83139
Reviewed-on: https://chromium-review.googlesource.com/377746
Reviewed-by: Mark Mentovai <mark@chromium.org>
Diffstat (limited to 'src/tools/mac/crash_report/on_demand_symbol_supplier.mm')
| -rw-r--r-- | src/tools/mac/crash_report/on_demand_symbol_supplier.mm | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/tools/mac/crash_report/on_demand_symbol_supplier.mm b/src/tools/mac/crash_report/on_demand_symbol_supplier.mm index ebbca87a..1955d266 100644 --- a/src/tools/mac/crash_report/on_demand_symbol_supplier.mm +++ b/src/tools/mac/crash_report/on_demand_symbol_supplier.mm @@ -27,6 +27,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +#import <Foundation/Foundation.h> #include <sys/stat.h> #include <map> #include <string> @@ -280,11 +281,8 @@ bool OnDemandSymbolSupplier::GenerateSymbolFile(const CodeModule *module, } if (generate_file) { - NSString *module_str = [[NSFileManager defaultManager] - stringWithFileSystemRepresentation:module_path.c_str() - length:module_path.length()]; DumpSymbols dump(ALL_SYMBOL_DATA, false); - if (dump.Read(module_str)) { + if (dump.Read(module_path)) { // What Breakpad calls "x86" should be given to the system as "i386". std::string architecture; if (system_info->cpu.compare("x86") == 0) { @@ -303,7 +301,7 @@ bool OnDemandSymbolSupplier::GenerateSymbolFile(const CodeModule *module, result = false; } } else { - printf("Unable to open %s\n", [module_str UTF8String]); + printf("Unable to open %s\n", module_path.c_str()); result = false; } } |