aboutsummaryrefslogtreecommitdiff
path: root/src/tools/mac/crash_report
diff options
context:
space:
mode:
authormmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2010-08-25 16:19:58 +0000
committermmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2010-08-25 16:19:58 +0000
commit2452f06b164ce635ca8153d2fd9e49f14a4c3d1d (patch)
tree094813e1f25929a0f6a83c9d74d391a50c3dbd55 /src/tools/mac/crash_report
parentBreakpad DWARF Reader: Ignore padding at the end of the compilation unit. (diff)
downloadbreakpad-2452f06b164ce635ca8153d2fd9e49f14a4c3d1d.tar.xz
In on_demand_symbol_supplier, recognize architecture x86 and transform it to
i386 when requesting an on-demand dump of symbols. The string is passed to system routines that understand this architecture as i386. Review URL: http://breakpad.appspot.com/162001 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@668 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/tools/mac/crash_report')
-rw-r--r--src/tools/mac/crash_report/on_demand_symbol_supplier.mm10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/tools/mac/crash_report/on_demand_symbol_supplier.mm b/src/tools/mac/crash_report/on_demand_symbol_supplier.mm
index 4cc64f6a..ad55412f 100644
--- a/src/tools/mac/crash_report/on_demand_symbol_supplier.mm
+++ b/src/tools/mac/crash_report/on_demand_symbol_supplier.mm
@@ -251,7 +251,15 @@ bool OnDemandSymbolSupplier::GenerateSymbolFile(const CodeModule *module,
length:module_path.length()];
DumpSymbols dump;
if (dump.Read(module_str)) {
- if (dump.SetArchitecture(system_info->cpu)) {
+ // What Breakpad calls "x86" should be given to the system as "i386".
+ std::string architecture;
+ if (system_info->cpu.compare("x86") == 0) {
+ architecture = "i386";
+ } else {
+ architecture = system_info->cpu;
+ }
+
+ if (dump.SetArchitecture(architecture)) {
FILE *file = fopen([symbol_path fileSystemRepresentation],"w");
if (file) {
dump.WriteSymbolFile(file);