diff options
| author | Michael Forney <mforney@mforney.org> | 2020-03-12 18:20:58 -0700 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2020-03-13 01:50:14 +0000 |
| commit | a5fa28ddf0396e0cd77defde67d64cb8cde30a34 (patch) | |
| tree | 7fadce62cd5087268f1c72ad0220ef3023798dd3 /src/tools/windows/converter_exe/converter.gyp | |
| parent | Remove sys/signal.h compatibility header (diff) | |
| download | breakpad-a5fa28ddf0396e0cd77defde67d64cb8cde30a34.tar.xz | |
Fix some bugs in CheckMicrodumpContents
The crash address from the microdump was never checked against
anything. Instead, the test was checking the value of a constant.
On 32-bit systems, an intptr_t cannot represent kCrashAddress
(0xDEADDEAD), causing a failure when the crash address is parsed
from the microdump. Instead, use uintptr_t, which matches the type
of kCrashAddress.
Change-Id: Ib5612743803609f7801dcfb98deaa8779e362025
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2100816
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/tools/windows/converter_exe/converter.gyp')
0 files changed, 0 insertions, 0 deletions