diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2017-03-10 23:09:14 +0000 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2017-03-17 17:49:55 +0000 |
| commit | 4bb0cd4743d1439f3f647595d7096c1f8715b755 (patch) | |
| tree | eca4cf82ed61258a976d698763d4aa0945800abe /src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc | |
| parent | [MIPS]: Don't terminate stackwalk when $sp value doesn't change between frames (diff) | |
| download | breakpad-4bb0cd4743d1439f3f647595d7096c1f8715b755.tar.xz | |
Fix issues with Windows dump_syms_unittest
* Turn DumpSymsRegressionTest into a parameterized test so it's easier to
see which test file is failing
* Convert dump_syms_regtest.sym to DOS line endings, being careful to
preserve the required spaces at the end of 'STACK WIN' lines
* In test #4 (omap_reorder_bbs), since the .exe corresponding to the .pdb is
not present, no INFO line is generated in the .sym file. Update .sym file.
* Stop collecting stderr from dump_syms. Future work: perhaps it's worth
collecting stderr to compare with a different file to verify that "Couldn't
locate EXE or DLL file" is output when expected?
* Regenerate testdata for test #5 (dump_syms_regtest64), which currently
does not pass, seemingly due a mis-match in the PDB age between the .pdb
file and the .sym file. Also add the .exe corresponding to the .pdb
present, to provide CFI
BUG=
Change-Id: I54fab866437c9e1bad3a5534cef4fe4b6ae47cd2
Reviewed-on: https://chromium-review.googlesource.com/453178
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc')
| -rw-r--r-- | src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc b/src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc index e5cc5cf9..e8efbeb8 100644 --- a/src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc +++ b/src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc @@ -27,9 +27,15 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +// with 32-bit cl // cl /Zi dump_syms_regtest.cc /link /PROFILE // dump_syms dump_syms_regtest.pdb > dump_syms_regtest.sym +// with 64-bit cl +// cp dump_syms_regtest.cc dump_syms_regtest64.cc +// cl /Zi dump_syms_regtest64.cc /link /PROFILE +// dump_syms dump_syms_regtest64.pdb > dump_syms_regtest64.sym + namespace google_breakpad { class C { |