diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2017-03-10 23:09:14 +0000 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2017-03-17 17:49:55 +0000 |
| commit | 4bb0cd4743d1439f3f647595d7096c1f8715b755 (patch) | |
| tree | eca4cf82ed61258a976d698763d4aa0945800abe /src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym | |
| parent | [MIPS]: Don't terminate stackwalk when $sp value doesn't change between frames (diff) | |
| download | breakpad-4bb0cd4743d1439f3f647595d7096c1f8715b755.tar.xz | |
Fix issues with Windows dump_syms_unittest
* Turn DumpSymsRegressionTest into a parameterized test so it's easier to
see which test file is failing
* Convert dump_syms_regtest.sym to DOS line endings, being careful to
preserve the required spaces at the end of 'STACK WIN' lines
* In test #4 (omap_reorder_bbs), since the .exe corresponding to the .pdb is
not present, no INFO line is generated in the .sym file. Update .sym file.
* Stop collecting stderr from dump_syms. Future work: perhaps it's worth
collecting stderr to compare with a different file to verify that "Couldn't
locate EXE or DLL file" is output when expected?
* Regenerate testdata for test #5 (dump_syms_regtest64), which currently
does not pass, seemingly due a mis-match in the PDB age between the .pdb
file and the .sym file. Also add the .exe corresponding to the .pdb
present, to provide CFI
BUG=
Change-Id: I54fab866437c9e1bad3a5534cef4fe4b6ae47cd2
Reviewed-on: https://chromium-review.googlesource.com/453178
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym')
| -rw-r--r-- | src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym b/src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym index 6f5cd1bd..39815245 100644 --- a/src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym +++ b/src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym @@ -1,6 +1,6 @@ MODULE windows x86_64 72E103A85CB249078B76B2E7C06257B13 dump_syms_regtest64.pdb
-INFO CODE_ID 5357F5C01A000 dump_syms_regtest64.exe
-FILE 1 d:\src\breakpad\src\tools\windows\dump_syms\testdata\dump_syms_regtest64.cc
+INFO CODE_ID 589DFD111A000 dump_syms_regtest64.exe
+FILE 1 c:\cygwin64\wip\breakpad-depot\src\src\tools\windows\dump_syms\testdata\dump_syms_regtest.cc
FILE 2 f:\dd\vctools\crt\crtw32\misc\amd64\amdsecgs.asm
FILE 3 f:\dd\ExternalAPIs\Windows\WinBlue\sdk\inc\ksamd64.inc
FILE 4 f:\dd\ExternalAPIs\Windows\WinBlue\sdk\inc\kxamd64.inc
|