diff options
| author | rmcilroy@chromium.org <rmcilroy@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-07-22 11:34:11 +0000 |
|---|---|---|
| committer | rmcilroy@chromium.org <rmcilroy@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2014-07-22 11:34:11 +0000 |
| commit | 561f81873562d407ac1c39144b30e26163e0045d (patch) | |
| tree | 7f2c072ddac47a40a34e46a36784dfcdd4fc411e /src/tools | |
| parent | Both std::tr1::unordered_set and std::unordered_set are not allowed in (diff) | |
| download | breakpad-561f81873562d407ac1c39144b30e26163e0045d.tar.xz | |
Chrome on Android now supports loading the shared library directly from the APK file.
This patch makes two changes to breakpad to enable crash reporting to work correctly when the library is inside another file (an archive):
- Do not filter mappings which map an executable at a non-zero offset.
- If such an executable is mapped look in the ELF information for the
shared object name and use that name in the minidump.
Note this change doesn't care about the archive format and isn't Android
specific (though loading the shared library this way is currently only done on Android).
BUG=390618
R=thestig@chromium.org
Review URL: https://breakpad.appspot.com/7684002
Patch from Anton Carver <anton@chromium.org>.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1355 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/linux/md2core/minidump-2-core.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/linux/md2core/minidump-2-core.cc b/src/tools/linux/md2core/minidump-2-core.cc index 92bd41e7..815e6e75 100644 --- a/src/tools/linux/md2core/minidump-2-core.cc +++ b/src/tools/linux/md2core/minidump-2-core.cc @@ -997,7 +997,7 @@ main(int argc, char** argv) { if (argc != argi + 1) return usage(argv[0]); - MemoryMappedFile mapped_file(argv[argi]); + MemoryMappedFile mapped_file(argv[argi], 0); if (!mapped_file.data()) { fprintf(stderr, "Failed to mmap dump file\n"); return 1; |