aboutsummaryrefslogtreecommitdiff
path: root/src/tools
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e>2011-10-11 17:38:01 +0000
committermark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e>2011-10-11 17:38:01 +0000
commita75f1bf9e7abbd52a7b495613ada2df554cc592d (patch)
tree0b3131dff657989a8a93fe5a90ae9a4cd7efdb9f /src/tools
parentRemove duplicate definition of GTMLoggerDebug. (diff)
downloadbreakpad-a75f1bf9e7abbd52a7b495613ada2df554cc592d.tar.xz
Fix harmless printf abuse in symupload.
symupload printed -[NSData length], an NSUInteger, using %lu. %lu is proper to print a "long" as unsigned, but NSUInteger is a typedef for "unsigned int" when building for 32-bit. This would not have caused any problems, because in the 32-bit model, both int and long are 32 bits wide. In the 64-bit model, long is 64 bits wide, but NSUInteger is defiend as "unsigned long", so there wouldn't have even been a warning in that case. This addresses the following warning: symupload.m:137:30:{137:28-137:31}{137:46-137:59}: warning: conversion specifies type 'unsigned long' but the argument has type 'NSUInteger' (aka 'unsigned int') [-Wformat] Review URL: http://breakpad.appspot.com/313002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@860 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/tools')
-rw-r--r--src/tools/mac/symupload/symupload.m3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/tools/mac/symupload/symupload.m b/src/tools/mac/symupload/symupload.m
index fe0cb67c..fe413458 100644
--- a/src/tools/mac/symupload/symupload.m
+++ b/src/tools/mac/symupload/symupload.m
@@ -134,7 +134,8 @@ static void Start(Options *options) {
fprintf(stdout, "Send: %s\n", error ? [[error description] UTF8String] :
"No Error");
fprintf(stdout, "Response: %d\n", status);
- fprintf(stdout, "Result: %lu bytes\n%s\n", [data length], [result UTF8String]);
+ fprintf(stdout, "Result: %lu bytes\n%s\n",
+ (unsigned long)[data length], [result UTF8String]);
[result release];
[ul release];