diff options
| author | ivan.penkov@gmail.com <ivan.penkov@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-11-21 01:33:08 +0000 |
|---|---|---|
| committer | ivan.penkov@gmail.com <ivan.penkov@gmail.com@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-11-21 01:33:08 +0000 |
| commit | c937b0ee01594d1e285a96a65c2f3a05eb2658dc (patch) | |
| tree | 4e2527ec4e9a740efb538f790f49415613497854 /src/tools | |
| parent | Add optional file size limit for minidumps (diff) | |
| download | breakpad-c937b0ee01594d1e285a96a65c2f3a05eb2658dc.tar.xz | |
Cleaning up google-breakpad source code of signed-unsigned comparison warnings
http://breakpad.appspot.com/488002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1083 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/linux/md2core/minidump-2-core.cc | 2 | ||||
| -rw-r--r-- | src/tools/linux/md2core/minidump_memory_range_unittest.cc | 14 |
2 files changed, 8 insertions, 8 deletions
diff --git a/src/tools/linux/md2core/minidump-2-core.cc b/src/tools/linux/md2core/minidump-2-core.cc index cbcbb1e6..b29d317a 100644 --- a/src/tools/linux/md2core/minidump-2-core.cc +++ b/src/tools/linux/md2core/minidump-2-core.cc @@ -675,7 +675,7 @@ ParseDSODebugInfo(CrashedProcess* crashinfo, const MinidumpMemoryRange& range, range.length() - sizeof(MDRawDebug)); } if (debug->map != kInvalidMDRVA) { - for (int i = 0; i < debug->dso_count; ++i) { + for (unsigned int i = 0; i < debug->dso_count; ++i) { const MDRawLinkMap* link_map = full_file.GetArrayElement<MDRawLinkMap>(debug->map, i); if (link_map) { diff --git a/src/tools/linux/md2core/minidump_memory_range_unittest.cc b/src/tools/linux/md2core/minidump_memory_range_unittest.cc index 296f621a..f4994fe6 100644 --- a/src/tools/linux/md2core/minidump_memory_range_unittest.cc +++ b/src/tools/linux/md2core/minidump_memory_range_unittest.cc @@ -95,7 +95,7 @@ const size_t kNumElements = sizeof(kElements) / sizeof(kElements[0]); TEST(MinidumpMemoryRangeTest, DefaultConstructor) { MinidumpMemoryRange range; EXPECT_EQ(NULL, range.data()); - EXPECT_EQ(0, range.length()); + EXPECT_EQ(0U, range.length()); } TEST(MinidumpMemoryRangeTest, ConstructorWithDataAndLength) { @@ -108,7 +108,7 @@ TEST(MinidumpMemoryRangeTest, Reset) { MinidumpMemoryRange range; range.Reset(); EXPECT_EQ(NULL, range.data()); - EXPECT_EQ(0, range.length()); + EXPECT_EQ(0U, range.length()); range.Set(kBuffer, kBufferSize); EXPECT_EQ(kBufferPointer, range.data()); @@ -116,7 +116,7 @@ TEST(MinidumpMemoryRangeTest, Reset) { range.Reset(); EXPECT_EQ(NULL, range.data()); - EXPECT_EQ(0, range.length()); + EXPECT_EQ(0U, range.length()); } TEST(MinidumpMemoryRangeTest, Set) { @@ -127,14 +127,14 @@ TEST(MinidumpMemoryRangeTest, Set) { range.Set(NULL, 0); EXPECT_EQ(NULL, range.data()); - EXPECT_EQ(0, range.length()); + EXPECT_EQ(0U, range.length()); } TEST(MinidumpMemoryRangeTest, SubrangeOfEmptyMemoryRange) { MinidumpMemoryRange range; MinidumpMemoryRange subrange = range.Subrange(0, 10); EXPECT_EQ(NULL, subrange.data()); - EXPECT_EQ(0, subrange.length()); + EXPECT_EQ(0U, subrange.length()); } TEST(MinidumpMemoryRangeTest, SubrangeAndGetData) { @@ -157,7 +157,7 @@ TEST(MinidumpMemoryRangeTest, SubrangeAndGetData) { EXPECT_FALSE(range.Covers(sub_offset, sub_length)); EXPECT_EQ(NULL, range.GetData(sub_offset, sub_length)); EXPECT_EQ(NULL, subrange.data()); - EXPECT_EQ(0, subrange.length()); + EXPECT_EQ(0U, subrange.length()); } } } @@ -185,7 +185,7 @@ TEST(MinidumpMemoryRangeTest, SubrangeWithMDLocationDescriptor) { EXPECT_FALSE(range.Covers(sub_offset, sub_length)); EXPECT_EQ(NULL, range.GetData(sub_offset, sub_length)); EXPECT_EQ(NULL, subrange.data()); - EXPECT_EQ(0, subrange.length()); + EXPECT_EQ(0U, subrange.length()); } } } |