aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorjimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e>2010-01-12 16:41:13 +0000
committerjimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e>2010-01-12 16:41:13 +0000
commit0441036f9ec45c3bc3037f2b407cf21a8006d66f (patch)
tree974affdc7d520c74ee07a61f7f54b93f65567d9c /src
parentIssue 49013: Breakpad Processor: Use a separate API to retrieve Windows stack... (diff)
downloadbreakpad-0441036f9ec45c3bc3037f2b407cf21a8006d66f.tar.xz
Breakpad: Avoid warnings building with G++ 4.4.1 using -O3 -Wall.
src/processor/minidump.cc:1067: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 3 has type ‘unsigned int’ src/processor/stackwalker_arm.cc:83: warning: unused variable ‘last_frame’ src/processor/minidump_stackwalk.cc:163: warning: ‘trust_name’ may be used uninitialized in this function a=jimblandy, r=ted.mielczarek git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@481 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src')
-rw-r--r--src/processor/minidump.cc2
-rw-r--r--src/processor/minidump_stackwalk.cc1
-rw-r--r--src/processor/stackwalker_arm.cc3
3 files changed, 2 insertions, 4 deletions
diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc
index d14f3a2c..f82c9a7e 100644
--- a/src/processor/minidump.cc
+++ b/src/processor/minidump.cc
@@ -1063,7 +1063,7 @@ void MinidumpContext::Print() {
for (unsigned int fpe_index = 0;
fpe_index < MD_FLOATINGSAVEAREA_ARM_FPEXTRA_COUNT;
++fpe_index) {
- printf(" float_save.extra[%2d] = 0x%" PRIx64 "\n",
+ printf(" float_save.extra[%2d] = 0x%" PRIx32 "\n",
fpe_index, context_arm->float_save.extra[fpe_index]);
}
diff --git a/src/processor/minidump_stackwalk.cc b/src/processor/minidump_stackwalk.cc
index 3701c466..6b7931bd 100644
--- a/src/processor/minidump_stackwalk.cc
+++ b/src/processor/minidump_stackwalk.cc
@@ -162,6 +162,7 @@ static void PrintStack(const CallStack *stack, const string &cpu) {
}
const char *trust_name;
switch (frame_x86->trust) {
+ default:
case StackFrameX86::FRAME_TRUST_NONE:
trust_name = "unknown";
break;
diff --git a/src/processor/stackwalker_arm.cc b/src/processor/stackwalker_arm.cc
index 484e75dc..a26e1e85 100644
--- a/src/processor/stackwalker_arm.cc
+++ b/src/processor/stackwalker_arm.cc
@@ -80,9 +80,6 @@ StackFrame* StackwalkerARM::GetCallerFrame(
return NULL;
}
- StackFrameARM *last_frame = static_cast<StackFrameARM*>(
- stack->frames()->back());
-
// TODO: Can't actually walk the stack on ARM without the CFI data.
// Implement this when the CFI symbol dumper changes have landed.
return NULL;