diff options
| author | Mark Mentovai <mark@chromium.org> | 2019-04-08 20:08:59 -0400 |
|---|---|---|
| committer | Mark Mentovai <mark@chromium.org> | 2019-04-09 00:09:28 +0000 |
| commit | 232c45abee1753785ae32938589eede535bdb06d (patch) | |
| tree | b2e7bba2dee0aebccbfe35549495bbd7ef625331 /src | |
| parent | linux_core_dumper: partially disable test on Android (diff) | |
| download | breakpad-232c45abee1753785ae32938589eede535bdb06d.tar.xz | |
linux_core_dumper: add missing newline to Android test-disabled message
The [ OK ] LinuxCoreDumperTest.VerifyExceptionDetails line does
not appear at the beginning of a line, hiding it from Chromium’s test
infrastructure. This causes the test to have an unknown result, which is
treated as a failure.
https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/233129
Bug: google-breakpad:791
Change-Id: I0eb646a219fa40347db884fd28ace647328c5e49
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1558893
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/client/linux/minidump_writer/linux_core_dumper_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc index 314257d9..212b151b 100644 --- a/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc @@ -94,7 +94,7 @@ TEST(LinuxCoreDumperTest, VerifyDumpWithMultipleThreads) { struct stat st; if (stat(core_file.c_str(), &st) != 0) { fprintf(stderr, "LinuxCoreDumperTest.VerifyDumpWithMultipleThreads test is " - "skipped due to no core file being generated"); + "skipped due to no core file being generated\n"); return; } #endif @@ -155,7 +155,7 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) { struct stat st; if (stat(core_file.c_str(), &st) != 0) { fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is " - "skipped due to no core file being generated"); + "skipped due to no core file being generated\n"); return; } #endif @@ -170,7 +170,7 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) { // TODO: For some reason, Android doesn't seem to pass this. if (!dumper.crash_address()) { fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is " - "skipped due to missing signal details on Android"); + "skipped due to missing signal details on Android\n"); return; } #endif |