aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authormmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2007-05-25 19:10:19 +0000
committermmentovai <mmentovai@4c0a9323-5329-0410-9bdc-e9ce6186880e>2007-05-25 19:10:19 +0000
commit6ed453a770a18ec0c5c7caaab60f5fff531b6608 (patch)
treef07e99fa9911f6e9395d52405f0c7bc4ab5a1427 /src
parentProvide for logging initialization routines (#179). r=bryner (diff)
downloadbreakpad-6ed453a770a18ec0c5c7caaab60f5fff531b6608.tar.xz
Processor can attempt processing all threads even when interrupted (#177).
r=ted.mielczarek http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8fda7c96fa7b5d57 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@178 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src')
-rw-r--r--src/processor/minidump_processor.cc12
1 files changed, 9 insertions, 3 deletions
diff --git a/src/processor/minidump_processor.cc b/src/processor/minidump_processor.cc
index a2a31427..6ab8c07d 100644
--- a/src/processor/minidump_processor.cc
+++ b/src/processor/minidump_processor.cc
@@ -112,6 +112,7 @@ MinidumpProcessor::ProcessResult MinidumpProcessor::Process(
(has_dump_thread ? "" : "no ") << "dump thread, and " <<
(has_requesting_thread ? "" : "no ") << "requesting thread";
+ bool interrupted = false;
bool found_requesting_thread = false;
unsigned int thread_count = threads->thread_count();
for (unsigned int thread_index = 0;
@@ -203,13 +204,18 @@ MinidumpProcessor::ProcessResult MinidumpProcessor::Process(
scoped_ptr<CallStack> stack(new CallStack());
if (!stackwalker->Walk(stack.get())) {
- BPLOG(INFO) << "Processing interrupted by stackwalker (missing " <<
- "symbols?) at " << thread_string;
- return PROCESS_INTERRUPTED;
+ BPLOG(INFO) << "Stackwalker interrupt (missing symbols?) at " <<
+ thread_string;
+ interrupted = true;
}
process_state->threads_.push_back(stack.release());
}
+ if (interrupted) {
+ BPLOG(INFO) << "Processing interrupted for " << minidump_file;
+ return PROCESS_INTERRUPTED;
+ }
+
// If a requesting thread was indicated, it must be present.
if (has_requesting_thread && !found_requesting_thread) {
// Don't mark as an error, but invalidate the requesting thread