diff options
| author | Mark Mentovai <mark@chromium.org> | 2019-11-01 03:49:03 +0000 |
|---|---|---|
| committer | Mark Mentovai <mark@chromium.org> | 2019-11-01 03:49:20 +0000 |
| commit | 8c62281f8b21f1e368a5e091331175f42f38e5fe (patch) | |
| tree | 4a175b3fc54f71209816f0cc3a64df7faecedb65 /src | |
| parent | linux, client: set module name from DT_SONAME (diff) | |
| download | breakpad-8c62281f8b21f1e368a5e091331175f42f38e5fe.tar.xz | |
Revert "Remove use of "register" keyword, deprecated in C++17"
This reverts commit 07411862eaa9a9a38e84caed2e97e836e456656f.
We were a bit overzealous in removing “register” here. Both clang and
GCC correctly disallow “register” as a storage class specifier in C++17
mode by producing an error in ordinary use. However, they require
“register” to be specified for explicit register variables, and do not
produce an error in this case.
Change-Id: I223f2652c6da4215d6e8788d902e767c94b8c29d
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1894875
Reviewed-by: Mark Mentovai <mark@chromium.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc b/src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc index 2dfe09b6..3ad48e50 100644 --- a/src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc +++ b/src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc @@ -65,7 +65,7 @@ void *thread_function(void *data) { perror("ERROR: parent notification failed"); return NULL; } - volatile pid_t *thread_id_ptr asm(TID_PTR_REGISTER) = thread_id; + register volatile pid_t *thread_id_ptr asm(TID_PTR_REGISTER) = thread_id; while (true) asm volatile ("" : : "r" (thread_id_ptr)); return NULL; |