diff options
| author | digit@chromium.org <digit@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-10-09 17:15:06 +0000 |
|---|---|---|
| committer | digit@chromium.org <digit@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-10-09 17:15:06 +0000 |
| commit | b52be69e590ac13f30d104cb713cc31348547523 (patch) | |
| tree | 39154b23dd962d08b3f31d6c64b278de9378251d /src | |
| parent | Don't bail if a thread's stack pointer is invalid (diff) | |
| download | breakpad-b52be69e590ac13f30d104cb713cc31348547523.tar.xz | |
Fix the Android unit tests.
- One of the unit test binaries refused to link due to
missing linker flags.
- The WriteDSODebug() function now works on Android, so
do not special-case it anymore.
- Ensure android/run-checks.sh will complain properly if
the client unit test suite fails on Android. It used to
consider that such failures were acceptable. Note that
it still considers failures when running the tools and
processor test suite on the device normal (fixing this
is a lot harder, and these parts of Breakpad typically
never run on a device, but on the host).
Review URL: https://breakpad.appspot.com/482002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1066 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src')
| -rw-r--r-- | src/client/linux/minidump_writer/minidump_writer.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/client/linux/minidump_writer/minidump_writer.cc b/src/client/linux/minidump_writer/minidump_writer.cc index 43ad05b6..5a0f8c14 100644 --- a/src/client/linux/minidump_writer/minidump_writer.cc +++ b/src/client/linux/minidump_writer/minidump_writer.cc @@ -983,9 +983,6 @@ class MinidumpWriter { } bool WriteDSODebugStream(MDRawDirectory* dirent) { -#if defined(__ANDROID__) - return false; -#else ElfW(Phdr)* phdr = reinterpret_cast<ElfW(Phdr) *>(dumper_->auxv()[AT_PHDR]); char* base; int phnum = dumper_->auxv()[AT_PHNUM]; @@ -1106,7 +1103,6 @@ class MinidumpWriter { delete[] dso_debug_data; return true; -#endif } private: |