Linux multiprocess crash reporter: use pipe instead of socketpair in the client

A=Jed Davis <jld@mozilla.com> R=ted at https://breakpad.appspot.com/1724002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1390 4c0a9323-5329-0410-9bdc-e9ce6186880e

2 files changed, 2 insertions, 9 deletions

diff --git a/src/client/linux/crash_generation/crash_generation_client.cc b/src/client/linux/crash_generation/crash_generation_client.cc
index 2522c955..d8bfbbad 100644
--- a/src/client/linux/crash_generation/crash_generation_client.cc
+++ b/src/client/linux/crash_generation/crash_generation_client.cc
@@ -50,7 +50,7 @@ class CrashGenerationClientImpl : public CrashGenerationClient {
 
   virtual bool RequestDump(const void* blob, size_t blob_size) {
     int fds[2];
-    if (sys_socketpair(AF_UNIX, SOCK_STREAM, 0, fds) < 0)
+    if (sys_pipe(fds) < 0)
       return false;
     static const unsigned kControlMsgSize = CMSG_SPACE(sizeof(int));
 
diff --git a/src/client/linux/crash_generation/crash_generation_server.cc b/src/client/linux/crash_generation/crash_generation_server.cc
index 1abf826c..860e8bc9 100644
--- a/src/client/linux/crash_generation/crash_generation_server.cc
+++ b/src/client/linux/crash_generation/crash_generation_server.cc
@@ -275,14 +275,7 @@ CrashGenerationServer::ClientEvent(short revents)
   }
 
   // Send the done signal to the process: it can exit now.
-  memset(&msg, 0, sizeof(msg));
-  struct iovec done_iov;
-  done_iov.iov_base = const_cast<char*>("\x42");
-  done_iov.iov_len = 1;
-  msg.msg_iov = &done_iov;
-  msg.msg_iovlen = 1;
-
-  HANDLE_EINTR(sendmsg(signal_fd, &msg, MSG_DONTWAIT | MSG_NOSIGNAL));
+  // (Closing this will make the child's sys_read unblock and return 0.)
   close(signal_fd);
 
   return true;