aboutsummaryrefslogtreecommitdiff
path: root/src/processor/address_map-inl.h
diff options
context:
space:
mode:
Diffstat (limited to 'src/processor/address_map-inl.h')
-rw-r--r--src/processor/address_map-inl.h12
1 files changed, 9 insertions, 3 deletions
diff --git a/src/processor/address_map-inl.h b/src/processor/address_map-inl.h
index e09dcae5..d88b4fcc 100644
--- a/src/processor/address_map-inl.h
+++ b/src/processor/address_map-inl.h
@@ -36,7 +36,10 @@
#ifndef PROCESSOR_ADDRESS_MAP_INL_H__
#define PROCESSOR_ADDRESS_MAP_INL_H__
+#include <cassert>
+
#include "processor/address_map.h"
+#include "processor/logging.h"
namespace google_breakpad {
@@ -45,8 +48,11 @@ bool AddressMap<AddressType, EntryType>::Store(const AddressType &address,
const EntryType &entry) {
// Ensure that the specified address doesn't conflict with something already
// in the map.
- if (map_.find(address) != map_.end())
+ if (map_.find(address) != map_.end()) {
+ BPLOG(INFO) << "Store failed, address " << HexString(address) <<
+ " is already present";
return false;
+ }
map_.insert(MapValue(address, entry));
return true;
@@ -56,8 +62,8 @@ template<typename AddressType, typename EntryType>
bool AddressMap<AddressType, EntryType>::Retrieve(
const AddressType &address,
EntryType *entry, AddressType *entry_address) const {
- if (!entry)
- return false;
+ BPLOG_IF(ERROR, !entry) << "AddressMap::Retrieve requires |entry|";
+ assert(entry);
// upper_bound gives the first element whose key is greater than address,
// but we want the first element whose key is less than or equal to address.