diff options
author | Shatur95 <genaloner@gmail.com> | 2020-10-15 21:41:00 +0300 |
---|---|---|
committer | Shatur95 <genaloner@gmail.com> | 2020-10-15 21:41:00 +0300 |
commit | e17c715faf300bd120b13039843bb02e36ce1253 (patch) | |
tree | e17e318434f5d14b21ffe25f7e3be1e9fb0189f2 /singleapplication_p.cpp | |
parent | Merge pull request #113 from Shatur95/fix-conversion-warning (diff) | |
download | singleapplication-e17c715faf300bd120b13039843bb02e36ce1253.tar.xz |
Fix Clang Tidy warnings
readability-convert-member-functions-to-static
readability-static-accessed-through-instance
readability-make-member-function-const
readability-inconsistent-declaration-parameter-name
Diffstat (limited to 'singleapplication_p.cpp')
-rw-r--r-- | singleapplication_p.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/singleapplication_p.cpp b/singleapplication_p.cpp index bb154bf..55a6fcd 100644 --- a/singleapplication_p.cpp +++ b/singleapplication_p.cpp @@ -158,7 +158,7 @@ void SingleApplicationPrivate::genBlockServerName() blockServerName = appData.result().toBase64().replace("/", "_"); } -void SingleApplicationPrivate::initializeMemoryBlock() +void SingleApplicationPrivate::initializeMemoryBlock() const { auto *inst = static_cast<InstancesInfo*>( memory->data() ); inst->primary = false; @@ -176,7 +176,7 @@ void SingleApplicationPrivate::startPrimary() auto *inst = static_cast <InstancesInfo*>( memory->data() ); inst->primary = true; - inst->primaryPid = q->applicationPid(); + inst->primaryPid = QCoreApplication::applicationPid(); qstrncpy( inst->primaryUser, getUsername().toUtf8().data(), sizeof(inst->primaryUser) ); inst->checksum = blockChecksum(); instanceNumber = 0; @@ -211,7 +211,7 @@ void SingleApplicationPrivate::startSecondary() instanceNumber = inst->secondary; } -bool SingleApplicationPrivate::connectToPrimary( int timeout, ConnectionType connectionType ) +bool SingleApplicationPrivate::connectToPrimary( int msecs, ConnectionType connectionType ) { QElapsedTimer time; time.start(); @@ -233,14 +233,14 @@ bool SingleApplicationPrivate::connectToPrimary( int timeout, ConnectionType con socket->connectToServer( blockServerName ); if( socket->state() == QLocalSocket::ConnectingState ){ - socket->waitForConnected( static_cast<int>(timeout - time.elapsed()) ); + socket->waitForConnected( static_cast<int>(msecs - time.elapsed()) ); } // If connected break out of the loop if( socket->state() == QLocalSocket::ConnectedState ) break; // If elapsed time since start is longer than the method timeout return - if( time.elapsed() >= timeout ) return false; + if( time.elapsed() >= msecs ) return false; } } @@ -269,12 +269,12 @@ bool SingleApplicationPrivate::connectToPrimary( int timeout, ConnectionType con socket->write( header ); socket->write( initMsg ); - bool result = socket->waitForBytesWritten( static_cast<int>(timeout - time.elapsed()) ); + bool result = socket->waitForBytesWritten( static_cast<int>(msecs - time.elapsed()) ); socket->flush(); return result; } -quint16 SingleApplicationPrivate::blockChecksum() +quint16 SingleApplicationPrivate::blockChecksum() const { return qChecksum( static_cast <const char *>( memory->data() ), @@ -282,7 +282,7 @@ quint16 SingleApplicationPrivate::blockChecksum() ); } -qint64 SingleApplicationPrivate::primaryPid() +qint64 SingleApplicationPrivate::primaryPid() const { qint64 pid; @@ -294,7 +294,7 @@ qint64 SingleApplicationPrivate::primaryPid() return pid; } -QString SingleApplicationPrivate::primaryUser() +QString SingleApplicationPrivate::primaryUser() const { QByteArray username; |