Add tools/report-clang-tidy.sh

- Fix various clang-tidy warnings
- Fix use-after-free crash when deleting profiles

1 files changed, 3 insertions, 2 deletions

diff --git a/lib/webprofile/webprofilemanager.cpp b/lib/webprofile/webprofilemanager.cpp
index d22b75c..2fca224 100644
--- a/lib/webprofile/webprofilemanager.cpp
+++ b/lib/webprofile/webprofilemanager.cpp
@@ -27,8 +27,9 @@ WebProfileManager::~WebProfileManager()
                 if(!p.ptr->cachePath().isEmpty())
                     QDir(p.ptr->cachePath()).removeRecursively();
             }
+            const QString filename = p.settings->fileName();
             delete p.settings;
-            QFile::remove(p.settings->fileName());
+            QFile::remove(filename);
         } else if(p.settings != nullptr) {
 #ifdef QT_DEBUG
             qDebug("sync %s", qUtf8Printable(p.settings->fileName()));
@@ -132,7 +133,7 @@ void WebProfileManager::deleteProfile(const QString &id)
     }
 }
 
-void WebProfileManager::profileMenu(QMenu *menu, std::function<void(WebProfile *)> callback, WebProfile *current, bool checkable) const
+void WebProfileManager::profileMenu(QMenu *menu, const std::function<void(WebProfile *)> &callback, WebProfile *current, bool checkable) const
 {
     auto *group = new QActionGroup(menu);
     connect(menu, &QMenu::aboutToHide, group, &QActionGroup::deleteLater);