blob: c53660f2e753f101ecea5efcd4db016bb0bf0039 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
|
# Based on:
# https://github.com/lefticus/cpp_starter_project/blob/master/cmake/CompilerWarnings.cmake
# https://github.com/lefticus/cppbestpractices/blob/master/02-Use_the_Tools_Available.md
function(enable_warnings)
# only enable warnings for debug builds
if(NOT ${CMAKE_BUILD_TYPE} STREQUAL "Debug")
return()
endif()
set(MSVC_WARNINGS
/W4 # Baseline reasonable warnings
/w14242 # 'identifier': conversion from 'type1' to 'type1', possible loss of data
/w14254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data
/w14263 # 'function': member function does not override any base class virtual member function
/w14265 # 'classname': class has virtual functions, but destructor is not virtual instances of this class may not
# be destructed correctly
/w14287 # 'operator': unsigned/negative constant mismatch
/we4289 # nonstandard extension used: 'variable': loop control variable declared in the for-loop is used outside
# the for-loop scope
/w14296 # 'operator': expression is always 'boolean_value'
/w14311 # 'variable': pointer truncation from 'type1' to 'type2'
/w14545 # expression before comma evaluates to a function which is missing an argument list
/w14546 # function call before comma missing argument list
/w14547 # 'operator': operator before comma has no effect; expected operator with side-effect
/w14549 # 'operator': operator before comma has no effect; did you intend 'operator'?
/w14555 # expression has no effect; expected expression with side- effect
/w14619 # pragma warning: there is no warning number 'number'
/w14640 # Enable warning on thread un-safe static member initialization
/w14826 # Conversion from 'type1' to 'type_2' is sign-extended. This may cause unexpected runtime behavior.
/w14905 # wide string literal cast to 'LPSTR'
/w14906 # string literal cast to 'LPWSTR'
/w14928 # illegal copy-initialization; more than one user-defined conversion has been implicitly applied
/permissive- # standards conformance mode for MSVC compiler.
)
set(BASE_WARNINGS
-Wall # reasonable and standard
-Wextra
-Werror=pedantic # warn if non-standard C++ is used
-Wunused # warn on anything being unused
-Wshadow # warn the user if a variable declaration shadows one from a parent context
-Wnon-virtual-dtor # warn the user if a class with virtual functions has a non-virtual destructor.
# This helps catch hard to track down memory errors
-Werror=redundant-decls
-Woverloaded-virtual # warn if you overload (not override) a virtual function
-Werror=return-type
-Wold-style-cast # warn for c-style casts
-Wcast-align # warn for potential performance problem casts
-Wconversion # warn on type conversions that may lose data
-Wsign-conversion # warn on sign conversions
-Wnull-dereference # warn if a null dereference is detected
-Wdouble-promotion # warn if float is implicit promoted to double
-Wformat=2 # warn on security issues around functions that format output (ie printf)
-Wconsumed
#-Wlifetime
-mspeculative-load-hardening # Spectre v1 mitigation
-Wmisleading-indentation # warn if indentation implies blocks where blocks do not exist
#-Wduplicated-cond # warn if if / else chain has duplicated conditions
#-Wduplicated-branches # warn if if / else branches have duplicated code
#-Wlogical-op # warn about logical operations being used where bitwise were probably wanted
#-Wuseless-cast # warn if you perform a cast to the same type
)
if(MSVC)
add_compile_options(${MSVC_WARNINGS})
message(STATUS "added ${MSVC_WARNINGS}")
else()
add_compile_options(${BASE_WARNINGS})
message(STATUS "added ${BASE_WARNINGS}")
endif()
endfunction()
|
