diff options
| author | Michael Forney <mforney@mforney.org> | 2020-03-10 15:32:35 -0700 |
|---|---|---|
| committer | Mike Frysinger <vapier@chromium.org> | 2020-03-10 22:52:40 +0000 |
| commit | a03ad96dbd61e8c7e35c3601612d6080a8586adf (patch) | |
| tree | 313f330089c2b632374c1b762d3ae6a9e1bc6cc3 /src/client/linux | |
| parent | Use sched_yield instead of pthread_yield (diff) | |
| download | breakpad-a03ad96dbd61e8c7e35c3601612d6080a8586adf.tar.xz | |
Use standard header locations for poll.h and signal.h
sys/poll.h and sys/signal.h just redirect to the standardized
location for these headers, poll.h and signal.h.
On musl libc, including the incorrect header path results in a
warning, and since breakpad is built with -Werror, this is an error.
In exception_handler.cc, signal.h is already included earlier, so
we can drop the sys/signal.h include.
Bug: google-breakpad:631
Change-Id: If36d326453e3267d38a5b92ed1301f828e46befe
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2097344
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'src/client/linux')
4 files changed, 3 insertions, 4 deletions
diff --git a/src/client/linux/handler/exception_handler.cc b/src/client/linux/handler/exception_handler.cc index b895f6d7..ba5b4990 100644 --- a/src/client/linux/handler/exception_handler.cc +++ b/src/client/linux/handler/exception_handler.cc @@ -78,7 +78,6 @@ #include <sys/wait.h> #include <unistd.h> -#include <sys/signal.h> #include <sys/ucontext.h> #include <sys/user.h> #include <ucontext.h> diff --git a/src/client/linux/handler/exception_handler_unittest.cc b/src/client/linux/handler/exception_handler_unittest.cc index bcbf9c26..8d8809fa 100644 --- a/src/client/linux/handler/exception_handler_unittest.cc +++ b/src/client/linux/handler/exception_handler_unittest.cc @@ -27,12 +27,12 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +#include <poll.h> #include <pthread.h> #include <stdint.h> #include <unistd.h> #include <signal.h> #include <sys/mman.h> -#include <sys/poll.h> #include <sys/socket.h> #include <sys/uio.h> #include <sys/wait.h> diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc index a41dafce..ea6b9a12 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc @@ -36,13 +36,13 @@ #include <errno.h> #include <fcntl.h> #include <limits.h> +#include <poll.h> #include <unistd.h> #include <signal.h> #include <stdint.h> #include <string.h> #include <sys/mman.h> #include <sys/prctl.h> -#include <sys/poll.h> #include <sys/stat.h> #include <sys/types.h> diff --git a/src/client/linux/minidump_writer/minidump_writer_unittest.cc b/src/client/linux/minidump_writer/minidump_writer_unittest.cc index c951e69d..f2b3ba38 100644 --- a/src/client/linux/minidump_writer/minidump_writer_unittest.cc +++ b/src/client/linux/minidump_writer/minidump_writer_unittest.cc @@ -28,7 +28,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include <fcntl.h> -#include <sys/poll.h> +#include <poll.h> #include <sys/stat.h> #include <sys/syscall.h> #include <sys/types.h> |