aboutsummaryrefslogtreecommitdiff
path: root/src/client
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e>2013-06-27 20:55:45 +0000
committermark@chromium.org <mark@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e>2013-06-27 20:55:45 +0000
commitf33dd18fd26fc4fa3f0f53d29f57fdd894e8c4b6 (patch)
tree17c22d7f9ce37008447440d635cc0cd6774aa5bf /src/client
parentThis change is addressing a particularly nasty issue where the stackwalker (diff)
downloadbreakpad-f33dd18fd26fc4fa3f0f53d29f57fdd894e8c4b6.tar.xz
Fix a clang warning.
Since explanatoryDialogText returns something that migth be user input, this looks like a good change anyhow. ../../breakpad/src/client/mac/sender/crash_report_sender.m:269:38: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] [self explanatoryDialogText], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Patch by Nico Weber <thakis@chromium.org> Review URL: https://breakpad.appspot.com/607002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1195 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/client')
-rw-r--r--src/client/mac/sender/crash_report_sender.m12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/client/mac/sender/crash_report_sender.m b/src/client/mac/sender/crash_report_sender.m
index c591f0ca..37eb255e 100644
--- a/src/client/mac/sender/crash_report_sender.m
+++ b/src/client/mac/sender/crash_report_sender.m
@@ -265,11 +265,13 @@ const int kEmailMaxLength = 64;
}
} else {
// Create an alert panel to tell the user something happened
- NSPanel* alert = NSGetAlertPanel([self shortDialogMessage],
- [self explanatoryDialogText],
- NSLocalizedString(@"sendReportButton", @""),
- NSLocalizedString(@"cancelButton", @""),
- nil);
+ NSPanel* alert =
+ NSGetAlertPanel([self shortDialogMessage],
+ @"%@",
+ NSLocalizedString(@"sendReportButton", @""),
+ NSLocalizedString(@"cancelButton", @""),
+ nil,
+ [self explanatoryDialogText]);
// Pop the alert with an automatic timeout, and wait for the response
buttonPressed = [self runModalWindow:alert withTimeout:timeout];