aboutsummaryrefslogtreecommitdiff
path: root/src/processor/stackwalker_arm.h
diff options
context:
space:
mode:
authorjimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e>2010-01-14 19:17:36 +0000
committerjimblandy <jimblandy@4c0a9323-5329-0410-9bdc-e9ce6186880e>2010-01-14 19:17:36 +0000
commit2684b4dc196ca2da9466aa5391f5c0090739d2f6 (patch)
tree915b756348bebc378ba53e3137aa7ba09733b4b1 /src/processor/stackwalker_arm.h
parentBreakpad Linux dumper: STABS reader incorrectly assumes a single compilation ... (diff)
downloadbreakpad-2684b4dc196ca2da9466aa5391f5c0090739d2f6.tar.xz
Breakpad processor: Don't pass Windows stack walking information to all walkers.
At the moment, the StackWalker GetCallerFrame member function expects a vector of WindowsFrameInfo structures, even though WindowsFrameInfo is only used or useful on one one implementation (StackWalkerX86). This patch changes StackWalker::GetCallerFrame to no longer expect the WindowsFrameInfo structures, and changes all implementations to match. In particular, StackWalkerX86 is changed to find the WindowsFrameInfo data itself, and store a pointer to whatever it got in the StackFrame object itself (which is really a StackFrameX86). To allow GetCallerFrame implementations to look up stack walking data, StackWalker::resolver_ needs to be made protected, not private. a=jimblandy, r=mmentovai git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@491 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/processor/stackwalker_arm.h')
-rw-r--r--src/processor/stackwalker_arm.h4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/processor/stackwalker_arm.h b/src/processor/stackwalker_arm.h
index b9399dd7..b149bfb7 100644
--- a/src/processor/stackwalker_arm.h
+++ b/src/processor/stackwalker_arm.h
@@ -64,9 +64,7 @@ class StackwalkerARM : public Stackwalker {
// Implementation of Stackwalker, using arm context and stack conventions.
// TODO: currently stubbed out, needs CFI symbol dumper support
virtual StackFrame* GetContextFrame();
- virtual StackFrame* GetCallerFrame(
- const CallStack *stack,
- const vector< linked_ptr<WindowsFrameInfo> > &stack_frame_info);
+ virtual StackFrame* GetCallerFrame(const CallStack *stack);
// Stores the CPU context corresponding to the innermost stack frame to
// be returned by GetContextFrame.